Skip to content

Conversation

@HuakunShen
Copy link
Contributor

@HuakunShen HuakunShen commented Mar 20, 2025

@Fevol Fevol self-requested a review March 21, 2025 13:28
],
components: {
Head: './src/overrides/Head.astro',
// Head: './src/overrides/Head.astro',
Copy link
Owner

@Fevol Fevol Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this being commented? On my end (with the PR being locally merged), this works fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me there is error.
There was something wrong with .replace()
If you are sure it works you can modify this PR

Copy link
Owner

@Fevol Fevol Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I did not try building the site, so the opengraph images were never generated. Will fix the issue.

@Fevol
Copy link
Owner

Fevol commented Mar 21, 2025

Sorry for the delay, thank you very much for the PR!
All changes look great, I left some comments for a couple things I am unsure about.
I didn't realize that you had also made some changes to the config.ts, so I couldn't merge the PR as-is, but I did merge your changes locally.

@HuakunShen
Copy link
Contributor Author

I didn’t realize so many lines changed in config.ts.
Most kf them are because I ran auto format with vscode.
Other lines are for removing typescript errors.

@HuakunShen
Copy link
Contributor Author

You can checkout this pr and push to it.
You should have access to push as the maintainer.

@Fevol
Copy link
Owner

Fevol commented Mar 21, 2025

Alright, I also applied the remaining Astro.props breaking change withastro/starlight#2390, but that should now be the last of the issues - everything builds and works properly.
Thank you again for the PR, I really appreciate your help!
I will now switch over to Fevol/starlight-theme-obsidian#8, and after also fixing #9, I'll update both packages (hopefully in a couple hours).

@Fevol Fevol merged commit 1e4b1ce into Fevol:main Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants